Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stargate: Use HTTP instead of WebSocket for Tendermint RPC #47

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

youngjoon-lee
Copy link

@youngjoon-lee youngjoon-lee commented Jul 16, 2021

If the URL string doesn't have a http:// or https:// prefix, the CosmJS connects to Tendermint via WebSocket: https://github.com/medibloc/cosmjs/blob/5ee3f82b83c0d2ec12ce1f73d5a19781f343d2f2/packages/tendermint-rpc/src/tendermint34/tendermint34client.ts#L22.
Then, the following warning occurs when running Jest:

Jest did not exit one second after the test run has completed.
This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with --detectOpenHandles to troubleshoot this issue.

@youngjoon-lee youngjoon-lee self-assigned this Jul 16, 2021
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Base automatically changed from ft/na/strict to stargate July 19, 2021 01:22
@youngjoon-lee youngjoon-lee merged commit 1bd1580 into stargate Jul 19, 2021
@youngjoon-lee youngjoon-lee deleted the ft/na/use-http branch July 19, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants